Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize helper functions #166

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Organize helper functions #166

merged 10 commits into from
Jun 27, 2023

Conversation

stefan-nikolov96
Copy link
Contributor

Organize helper functions in /utils directory and substitute correct inclusions in other circuits.

Copy link
Collaborator

@Dimo99 Dimo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Squash the commits the commit message could be fix(circom): Organize helper functions
  • add tests to the util functions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file and move it to numerical.circom

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move RangeCheck to numerical

@stefan-nikolov96 stefan-nikolov96 force-pushed the organize_helper_functions branch 6 times, most recently from ad28bff to 137ef48 Compare June 27, 2023 10:38
@Dimo99 Dimo99 merged commit 843b9f7 into main Jun 27, 2023
@Dimo99 Dimo99 deleted the organize_helper_functions branch June 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants